mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59551: Change launcher working directory before dropping privilege.
Date Wed, 31 May 2017 21:29:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59551/#review176527
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 24, 2017, 11:45 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59551/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 11:45 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7476
>     https://issues.apache.org/jira/browse/MESOS-7476
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The launcher needs to change its working directory before dropping
> privilege by switching users and installing capabilities, because
> afterwards it might not have access to traverse to the desired
> working directory.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp f48d294a0a832dfe248c4a83849ee5a63cb76bce 
> 
> 
> Diff: https://reviews.apache.org/r/59551/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message