mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59662: Changed `Executor` and `Framework` to class.
Date Wed, 31 May 2017 21:12:37 GMT


> On May 31, 2017, 4:37 p.m., Anand Mazumdar wrote:
> > src/slave/slave.hpp
> > Lines 689 (patched)
> > <https://reviews.apache.org/r/59662/diff/1/?file=1735074#file1735074line691>
> >
> >     hmm, I like it the other way around i.e., since this class has a lot of public
fields, `struct` is more reasonable here. A `class` with default scoping as `public` seems
non-intuitive.
> >     
> >     @bmahler what do you think?

Google style suggests to use class over struct if the methods are non-trivial.
https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes

I like being more explicit. For the sake of consistency, I'll fix other places.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59662/#review176466
-----------------------------------------------------------


On May 30, 2017, 11:15 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59662/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 11:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It's wierd that `Executor` and `Framework` are struct, but they have
> `private` fields.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 
> 
> 
> Diff: https://reviews.apache.org/r/59662/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message