mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.
Date Wed, 31 May 2017 18:01:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/
-----------------------------------------------------------

(Updated May 31, 2017, 6:01 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Changes
-------

Rebase.


Bugs: MESOS-4945
    https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
-------

This includes the following changes:
- add a `pruneImages()` function on the chain of relevant classes;
- implement prune in docker store;
- fix mock interface to keep existing tests pass.


Diffs (updated)
-----

  src/slave/containerizer/composing.hpp bef6d880ca1d815fc21d9d017f6de2d26ad5218f 
  src/slave/containerizer/composing.cpp a003e1b80dc9b4dec5b3fbbadb2daecf855c90c7 
  src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c 
  src/slave/containerizer/docker.hpp b602a5698cae12686f51c4b9370a06042cda6270 
  src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de 
  src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d

  src/slave/containerizer/mesos/containerizer.cpp f3e6210eccd4a6b445ffd4447e69526d424ea36d

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab

  src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2

  src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7

  src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 8058dcb31b9de59fa8d3638b5511113632235542

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 3d4da9069c8bc8b71243f5ebd0d6f68b7d9c0cac

  src/slave/containerizer/mesos/provisioner/store.hpp 01ab83dca79e51b8c96d18ee65705912b0ac8324

  src/slave/containerizer/mesos/provisioner/store.cpp cc5cc81e05f29bb0e11ffa13cdb8d63d4397114f

  src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538 
  src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb 
  src/tests/containerizer/mock_containerizer.hpp 0adcb01e6c12d6cc4abed1f14fa2df833ffc6569



Diff: https://reviews.apache.org/r/56721/diff/3/

Changes: https://reviews.apache.org/r/56721/diff/2-3/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message