mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59549: Add the agent --bounding_capabilities flag.
Date Wed, 31 May 2017 16:23:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59549/#review176462
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/flags.cpp
Lines 603 (patched)
<https://reviews.apache.org/r/59549/#comment249821>

    I would do the same as that in `allowed_capabilities`
    
    ```
    containerizer (currently only supported in MesosContainerizer)
    ```



src/slave/flags.cpp
Lines 605 (patched)
<https://reviews.apache.org/r/59549/#comment249819>

    iff `linux/capabilities` isolator is enabled.



src/slave/flags.cpp
Lines 606 (patched)
<https://reviews.apache.org/r/59549/#comment249820>

    ditto. `linux/capabilities` isolator is enabled.


- Jie Yu


On May 24, 2017, 11:45 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59549/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 11:45 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7476
>     https://issues.apache.org/jira/browse/MESOS-7476
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the agent --bounding_capabilities flag to enable the operator to
> specify a default bounding capabilities set.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp b66995630f89dfb95a6d0cf66efc5d7590e90cbc 
>   src/slave/flags.cpp 0c8276e425a6a7d22ee68edc6cc25b331635ec44 
> 
> 
> Diff: https://reviews.apache.org/r/59549/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message