mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 59081: Updated master to use resource provider IDs in allocator calls.
Date Wed, 31 May 2017 09:56:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59081/
-----------------------------------------------------------

(Updated May 31, 2017, 11:56 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Fixed `addSlave` call.


Repository: mesos


Description
-------

The allocator interface expects resource provider IDs instead of slave
IDs. The internal slave instance in the master will still use their
slave IDs and create a resource provider ID from them to provide
backwards compatibility.
A later patch will change the callbacks of the allocator, until then
the resource provider ID is copied from the slave ID of the callback.


Diffs (updated)
-----

  src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f 
  src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
  src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27 
  src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce 
  src/master/weights_handler.cpp a4d2fed758878f3e2b9557a61965816aa9e0399c 


Diff: https://reviews.apache.org/r/59081/diff/2/

Changes: https://reviews.apache.org/r/59081/diff/1-2/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message