mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.
Date Tue, 30 May 2017 23:40:45 GMT


> On May 30, 2017, 7:43 p.m., Mesos Reviewbot Windows wrote:
> > Bad patch!
> > 
> > Reviews applied: [59583, 59545, 59463, 59461, 59460]
> > 
> > Failed command: python support/apply-reviews.py -n -r 59545
> > 
> > Error:
> > error: patch failed: src/tests/slave_tests.cpp:7210
> > error: src/tests/slave_tests.cpp: patch does not apply
> > 
> > Full log: http://mesos-winbot.westus.cloudapp.azure.com/../logs/console

FYI the Windows ReviewBot is blocked from applying to master by https://reviews.apache.org/r/59500/

Bug Joe!


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176337
-----------------------------------------------------------


On May 30, 2017, 11:30 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 11:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7542
>     https://issues.apache.org/jira/browse/MESOS-7542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5 
> 
> 
> Diff: https://reviews.apache.org/r/59583/diff/3/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message