mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.
Date Tue, 30 May 2017 23:38:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59658/#review176393
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 296-302 (original), 296 (patched)
<https://reviews.apache.org/r/59658/#comment249763>

    This needs https://github.com/3rdparty/mesos-3rdparty/pull/12


- Andrew Schwartzmeyer


On May 30, 2017, 11:30 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59658/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 11:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jeff Coffler, Joseph Wu, Li Li, and Zhitao
Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reconciles the Linux and Windows builds to use the same version of
> Protobuf. Previously, Windows was using a 3.0.0-beta-2 while Linux was
> stuck on 2.6.1. Now they both use 3.3.0.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 815bea32a2b0ef75d29f273c652c3ed9fbaf88b5 
>   3rdparty/cmake/Versions.cmake 8a0537b390a66ed97181abdf2113211e130fc400 
> 
> 
> Diff: https://reviews.apache.org/r/59658/diff/1/
> 
> 
> Testing
> -------
> 
> Windows only changes; tested stout-tests, mesos-tests, libprocess-tests on Windows.
> 
> This unit test in mesos-tests is failing:
> 
> ```
> [ RUN      ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0
> *** Check failure stack trace: ***
> 
> Failed to chdir into current working directory 
> '
> C:\Users\mesos\AppData\Local\Temp\USO4Dr\slaves\276c0a68-02f3-4dd9-b024-6f599bd87f56-S0\frameworks\276c0a68-02f3-4dd9-b024-6f599bd87f56-0000\executors\test_default_executor\runs\4054de83-cb3b-47a2-b075
> -c8c78e704ce2\containers\fbe4664b-c94a-4d23-a9ea-baace0d58000
> ': 
> No such file or directory
> 
> 
> Failed to chdir into current working directory 
> 'C:\Users\mesos\AppData\Local\Temp\USO4Dr\slaves\276c0a68-02f3-4dd9-b024-6f599bd87f56-S0\frameworks\276c0a68-02f3-4dd9-b024-6f599bd87f56-0000\executors\test_default_executor\runs\4054de83-cb3b-47a2-b07
> 5-c8c78e704ce2\containers\8df62ab2-4784-4739-a2c4-4cee0bb81d3f': No such file or directory
> 
> C:\Users\mesos\mesos-dev\src\tests\default_executor_tests.cpp(912): error: Failed to
wait 15secs for updateRunning1
> C:\Users\mesos\mesos-dev\src\tests\default_executor_tests.cpp(898): error: Actual function
call count doesn't match EXPECT_CALL(*scheduler, update(_, _))...
>          Expected: to be called twice
>            Actual: never called - unsatisfied and active
> [  FAILED  ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where
GetParam() = "mesos" (15509 ms)
> ```
> 
> But it seems unreleated (it's failing due to a directory not getting made; shouldn't
be related to protobuf being updated from 3.0.0-beta2 to 3.3.0).
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message