mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 59658: Windows: Updated Protobuf to 3.3.0.
Date Tue, 30 May 2017 23:30:42 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 30, 2017, 11:30 p.m.)

Review request for mesos, Anand Mazumdar, Jeff Coffler, Joseph Wu, Li Li, and Zhitao Li.

Repository: mesos


This reconciles the Linux and Windows builds to use the same version of
Protobuf. Previously, Windows was using a 3.0.0-beta-2 while Linux was
stuck on 2.6.1. Now they both use 3.3.0.


  3rdparty/CMakeLists.txt 815bea32a2b0ef75d29f273c652c3ed9fbaf88b5 
  3rdparty/cmake/Versions.cmake 8a0537b390a66ed97181abdf2113211e130fc400 


Testing (updated)

Windows only changes; tested stout-tests, mesos-tests, libprocess-tests on Windows.

This unit test in mesos-tests is failing:

[ RUN      ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0
*** Check failure stack trace: ***

Failed to chdir into current working directory 
No such file or directory

Failed to chdir into current working directory 
5-c8c78e704ce2\containers\8df62ab2-4784-4739-a2c4-4cee0bb81d3f': No such file or directory

C:\Users\mesos\mesos-dev\src\tests\default_executor_tests.cpp(912): error: Failed to wait
15secs for updateRunning1
C:\Users\mesos\mesos-dev\src\tests\default_executor_tests.cpp(898): error: Actual function
call count doesn't match EXPECT_CALL(*scheduler, update(_, _))...
         Expected: to be called twice
           Actual: never called - unsatisfied and active
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam()
= "mesos" (15509 ms)

But it seems unreleated (it's failing due to a directory not getting made; shouldn't be related
to protobuf being updated from 3.0.0-beta2 to 3.3.0).


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message