mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 59658: Windows: Updated Protobuf to 3.3.0.
Date Tue, 30 May 2017 23:24:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59658/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Jeff Coffler, Joseph Wu, Li Li, and Zhitao Li.


Repository: mesos


Description
-------

This reconciles the Linux and Windows builds to use the same version of
Protobuf. Previously, Windows was using a 3.0.0-beta-2 while Linux was
stuck on 2.6.1. Now they both use 3.3.0.


Diffs
-----

  3rdparty/CMakeLists.txt 815bea32a2b0ef75d29f273c652c3ed9fbaf88b5 
  3rdparty/cmake/Versions.cmake 8a0537b390a66ed97181abdf2113211e130fc400 


Diff: https://reviews.apache.org/r/59658/diff/1/


Testing
-------

Windows only changes; tested stout-tests, mesos-tests, libprocess-tests on Windows.

This unit test in mesos-tests is failing:

```
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam()
= "mesos"
```

But it seems unreleated(?).


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message