mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.
Date Tue, 30 May 2017 21:13:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59634/
-----------------------------------------------------------

(Updated May 30, 2017, 9:13 p.m.)


Review request for mesos and Armand Grillet.


Changes
-------

Updated based on Armand's comments. I guess I just used it to run the follow on patch about
unit testing and never tested `mesos` itself!


Repository: mesos


Description
-------

Previously, we were importing settings directly from the `bin`
directory, which is obviously not portable. Instead, we need to be
passing the settings into the constructor for the config so that it
can access it from there.


Diffs (updated)
-----

  src/cli_new/bin/main.py d0ec2bdb04631fbaa62efb6ae67e138140a1296a 
  src/cli_new/lib/cli/config.py 353785b8bdc13b745d2dc9469201c16a8816ebc6 


Diff: https://reviews.apache.org/r/59634/diff/2/

Changes: https://reviews.apache.org/r/59634/diff/1-2/


Testing
-------

Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message