mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.
Date Tue, 30 May 2017 13:28:32 GMT


> On May 23, 2017, 3:59 p.m., Andrei Budnik wrote:
> > src/cli_new/lib/cli/tests/base.py
> > Lines 52 (patched)
> > <https://reviews.apache.org/r/58720/diff/6/?file=1711168#file1711168line52>
> >
> >     I would prefer os.linesep to '\n' here and everywhere to avoid extra constant.
> 
> Kevin Klues wrote:
>     The python documentation disagrees:
>     
>     https://docs.python.org/3.0/library/os.html
>     
>     ```
>     os.linesep
>     
>     The string used to separate (or, rather, terminate) lines on the current platform.
This may be a single character, such as '\n' for POSIX, or multiple characters, for example,
'\r\n' for Windows. Do not use os.linesep as a line terminator when writing files opened in
text mode (the default); use a single '\n' instead, on all platforms.
>     ```

Oh, I agree with you. Dropped the issue.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review175800
-----------------------------------------------------------


On May 30, 2017, 10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 10 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7283
>     https://issues.apache.org/jira/browse/MESOS-7283
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/tests/__init__.py PRE-CREATION 
>   src/cli_new/lib/cli/tests/base.py PRE-CREATION 
>   src/cli_new/lib/cli/tests/constants.py PRE-CREATION 
>   src/cli_new/lib/cli/tests/tests.py PRE-CREATION 
>   src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 
>   src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 
> 
> 
> Diff: https://reviews.apache.org/r/58720/diff/14/
> 
> 
> Testing
> -------
> 
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos-cli-tests
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message