mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 58137: Added 'mesos config show' command in the new Mesos CLI.
Date Mon, 29 May 2017 22:01:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review176275
-----------------------------------------------------------


Fix it, then Ship it!





src/cli_new/lib/cli/plugins/config/main.py
Lines 96-97 (patched)
<https://reviews.apache.org/r/58137/#comment249643>

    The space at the end of the first line should be at the beginning of the second line.
I will make this change myself before committing.


- Kevin Klues


On May 29, 2017, 3:46 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
> 
> (Updated May 29, 2017, 3:46 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This command displays the contents of the user-defined config.toml file.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/plugins/config/main.py 6e19e5c2e148b92323a6ea0e9a7610eb938a84d9

> 
> 
> Diff: https://reviews.apache.org/r/58137/diff/8/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message