mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 59616: Add `six` python package in install_require.
Date Mon, 29 May 2017 10:48:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59616/#review176262
-----------------------------------------------------------



This looks like the wrong fix to me. Mesos does not depend on `six` but our own dependency
`protobuf` does. I am not sure exactly what breakage this patch addresses, but we should probably
fix the way we pull in the Python protobuf package into our build instead of fixing its broken
dependencies by declaring incorrect deps.

Note there is also https://github.com/Homebrew/homebrew-core/pull/13876#issuecomment-303682598.
We should probably let them know about what release any solutions found here landed in.

- Benjamin Bannier


On May 27, 2017, 3:10 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59616/
> -----------------------------------------------------------
> 
> (Updated May 27, 2017, 3:10 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After protobuf 3.3.0 upgrade, reviewboard CI breaks complaining failed
> `import six` python.
> 
> 
> Diffs
> -----
> 
>   src/python/setup.py.in 991ac31409c566e8a59d47f8296317e245925d4e 
> 
> 
> Diff: https://reviews.apache.org/r/59616/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message