mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.
Date Fri, 26 May 2017 23:29:35 GMT


> On May 26, 2017, 9:52 a.m., Zhitao Li wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/59536/diff/1/?file=1731925#file1731925line30>
> >
> >     Can you explain how is these hashes geneareted and used?
> >     
> >     I'm working on upgrading protobuf library to 3.3.0 so this hash would change,
but I don't know how I can generate a correct value from here...

You can use any SHA-generating utility to get these hashes, like:
```
shasum -a 256 <file>
openssl sha -sha256 <file>
```


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review176208
-----------------------------------------------------------


On May 24, 2017, 12:13 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 12:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
>     File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fe8888a4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> -------
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message