mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 58360: Added a test for evolving large protobuf message.
Date Fri, 26 May 2017 16:34:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58360/#review176207
-----------------------------------------------------------


Fix it, then Ship it!




I would fix this minor thing before committing.


src/tests/protobuf_utils_tests.cpp
Lines 307 (patched)
<https://reviews.apache.org/r/58360/#comment249554>

    Extra new line.


- Anand Mazumdar


On May 19, 2017, 5:57 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58360/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 5:57 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-6644 and MESOS-7228
>     https://issues.apache.org/jira/browse/MESOS-6644
>     https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before protobuf 3.3.0, this test would fail because the 64MB limit
> imposed by older version of protobuf.
> 
> 
> Diffs
> -----
> 
>   src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328 
> 
> 
> Diff: https://reviews.apache.org/r/58360/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message