mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.
Date Fri, 26 May 2017 00:06:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/#review176155
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp
Lines 119 (patched)
<https://reviews.apache.org/r/59130/#comment249511>

    Let's be explicit and add namespace `inet` too so that the code is very clear when we're
working with v4 versus v6.



3rdparty/libprocess/src/process.cpp
Line 584 (original), 592 (patched)
<https://reviews.apache.org/r/59130/#comment249512>

    Do we want a inline struct of `addresses`?
    
    __addresses__.inet6 ? .v4?
    .unix
    
    ?


- Benjamin Hindman


On May 10, 2017, 7:08 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59130/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 7:08 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7488
>     https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The operator can specify a v6 address to be used by a `libprocess`
> process by specifying the `LIBPROCESS_IP6` environment variable.
> Currently the `lipbrocess` stores the IPv6 address but doesn't open a
> socket on the v6 address in order to listen or send traffic on the v6
> address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 
> 
> 
> Diff: https://reviews.apache.org/r/59130/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message