mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59500: Added Windows ReviewBot launch script.
Date Thu, 25 May 2017 21:35:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59500/#review176134
-----------------------------------------------------------




support/mesos-reviewbot.ps1
Lines 1 (patched)
<https://reviews.apache.org/r/59500/#comment249463>

    Need one of these at the top:
    ```
    # Licensed to the Apache Software Foundation (ASF) under one
    # or more contributor license agreements.  See the NOTICE file
    # distributed with this work for additional information
    # regarding copyright ownership.  The ASF licenses this file
    # to you under the Apache License, Version 2.0 (the
    # "License"); you may not use this file except in compliance
    # with the License.  You may obtain a copy of the License at
    #
    #     http://www.apache.org/licenses/LICENSE-2.0
    #
    # Unless required by applicable law or agreed to in writing, software
    # distributed under the License is distributed on an "AS IS" BASIS,
    # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    # See the License for the specific language governing permissions and
    # limitations under the License.
    ```



support/mesos-reviewbot.ps1
Lines 8 (patched)
<https://reviews.apache.org/r/59500/#comment249464>

    Did you leave this URL here intentionally?  Seems like something the user should specify.



support/mesos-reviewbot.ps1
Lines 10-16 (patched)
<https://reviews.apache.org/r/59500/#comment249465>

    The python check is fine, but adding the default install location doesn't seem necessary.



support/mesos-reviewbot.ps1
Lines 21-22 (patched)
<https://reviews.apache.org/r/59500/#comment249466>

    The `windows-build.bat` script defaults to this generator now.



support/mesos-reviewbot.ps1
Lines 25 (patched)
<https://reviews.apache.org/r/59500/#comment249467>

    Does `Sort-Object` sort alphabetically?  Or is it smart enough to sort `10` after `9`?



support/mesos-reviewbot.ps1
Lines 28 (patched)
<https://reviews.apache.org/r/59500/#comment249468>

    `verify-reviews.py` concatentates `BUILD_URL` + `console`.  So wouldn't the url end up
being `$folder/$i/console/console`?


- Joseph Wu


On May 23, 2017, 1:19 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59500/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 1:19 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a support script used to run the Windows ReviewBot in a loop,
> while properly logging the output and providing a URL for the log.
> 
> 
> Diffs
> -----
> 
>   support/mesos-reviewbot.ps1 PRE-CREATION 
>   support/verify-reviews.py 391bef5c15a7399f037e54600d1b13c9bd261811 
> 
> 
> Diff: https://reviews.apache.org/r/59500/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message