mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59537: Fixed a bug in 'ComposingContainerizerProcess::wait()'.
Date Thu, 25 May 2017 15:31:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59537/#review176078
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/composing.cpp
Lines 626 (patched)
<https://reviews.apache.org/r/59537/#comment249406>

    I wouldn't say this is a workaround. This is a proper fix for the issue :)



src/slave/containerizer/composing.cpp
Lines 627 (patched)
<https://reviews.apache.org/r/59537/#comment249407>

    kill this line


- Jie Yu


On May 24, 2017, 8:30 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59537/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7546
>     https://issues.apache.org/jira/browse/MESOS-7546
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a bug in the Composing Containerizer that would make it always
> immediately return 'None' when trying to wait on a nested container
> that had already been terminated and whose exit status was checkpointed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 0b6c76b3d081d86df81a6062ae7a191ba8dadfde 
> 
> 
> Diff: https://reviews.apache.org/r/59537/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux, plus manual testing using an agent that uses both the Docker
and the Mesos containerizers.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message