mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 58964: Added authorization support for operator endpoints.
Date Wed, 24 May 2017 13:17:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58964/
-----------------------------------------------------------

(Updated May 24, 2017, 3:17 p.m.)


Review request for mesos, Adam B and Greg Mann.


Changes
-------

Updated documentation.


Bugs: MESOS-7415
    https://issues.apache.org/jira/browse/MESOS-7415


Repository: mesos


Description
-------

Adds the actions `UPDATE_MAINTENANCE_SCHEDULE`,
`GET_MAINTENANCE_SCHEDULE`, `START_MAINTENANCE`, `STOP_MAINTENANCE`
and `GET_MAINTENANCE_STATUS` to the authorizer API as well as the
necesary code to handle these new actions.

While the interface `mesos::Authorizer` takes an object with type
`MachineID` to perform authorization; the default implementation of
the interface `mesos::LocalAuthorizer` ignores the object choosing the
semantics of allow maintenance on all nodes or none. This was done to
extend the capacities of custom authorizers which may have special
rules for authorization.


Diffs (updated)
-----

  docs/authorization.md d94f0f9d142e66118b89ecac28b9a4b21e88b6c8 
  include/mesos/authorizer/acls.proto ae0b1ea2e6417d186b1606542d75f3a20e0811db 
  include/mesos/authorizer/authorizer.hpp 4a7376fb6ca2be0a513ad54f56eea3cf8cdd024d 
  include/mesos/authorizer/authorizer.proto c9184d151befa4cea9bdebb36a315c760e6424b2 
  src/authorizer/local/authorizer.cpp 89aaf4b712d337d519445c922606789c334e5101 
  src/tests/authorization_tests.cpp 32aa6ac4db7854507127ea2fb88b3e92daa277c0 


Diff: https://reviews.apache.org/r/58964/diff/5/

Changes: https://reviews.apache.org/r/58964/diff/4-5/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message