mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 53842: Add specific metrics for sorting runs across frameworks of a role.
Date Wed, 24 May 2017 04:26:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------

(Updated May 24, 2017, 4:26 a.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
-------

Rebased after the 1st patch in the chain was pushed.


Bugs: MESOS-6579
    https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description (updated)
-------

Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/sort_run_ms: Number of framework
   level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/sort_run_ms: Latency in framework
   level sorts (based on role) in DRF Sorter.


Diffs (updated)
-----

  docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 
  src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/mesos/hierarchical.cpp 5511bf6ce8c866c8a8436595f5b3eb1ef81c999f 
  src/tests/hierarchical_allocator_tests.cpp f911110068a50c822aa90b864329ae87c9b5f8bb 


Diff: https://reviews.apache.org/r/53842/diff/8/

Changes: https://reviews.apache.org/r/53842/diff/7-8/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message