mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 53841: Added metrics for sorting in the role and quota sorters.
Date Wed, 24 May 2017 04:23:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53841/
-----------------------------------------------------------

(Updated May 24, 2017, 4:23 a.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
-------

Rebased after the 1st patch in the chain was pushed.


Bugs: MESOS-6579
    https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description
-------

Following metrics have been added:
a) allocator/mesos/roles/sort_runs: Number of role level sorts.
b) allocator/mesos/roles/sort_run: Latency in role level sorts.
c) allocator/mesos/quotas/sort_runs: Number of quota level sorts.
d) allocator/mesos/quotas/sort_run: Latency in quota level sorts.


Diffs (updated)
-----

  docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e 
  src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/sorter/drf/metrics.hpp 61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
  src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff 
  src/master/allocator/sorter/drf/sorter.cpp 26b77f578f3235a8792c72d4575d607cdb2c7de7 
  src/tests/hierarchical_allocator_tests.cpp f911110068a50c822aa90b864329ae87c9b5f8bb 


Diff: https://reviews.apache.org/r/53841/diff/7/

Changes: https://reviews.apache.org/r/53841/diff/6-7/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message