mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 59463: Added test for agent ping timeout during agent recovery.
Date Wed, 24 May 2017 01:27:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59463/#review175888
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_recovery_tests.cpp
Lines 807 (patched)
<https://reviews.apache.org/r/59463/#comment249233>

    "re-registration"



src/tests/slave_recovery_tests.cpp
Lines 810-812 (patched)
<https://reviews.apache.org/r/59463/#comment249241>

    elapsed, even if the executors are all re-registered



src/tests/slave_recovery_tests.cpp
Lines 811 (patched)
<https://reviews.apache.org/r/59463/#comment249234>

    "re-registration"



src/tests/slave_recovery_tests.cpp
Lines 812 (patched)
<https://reviews.apache.org/r/59463/#comment249237>

    (see MESOS-7539).



src/tests/slave_recovery_tests.cpp
Lines 894 (patched)
<https://reviews.apache.org/r/59463/#comment249238>

    issue (see MESOS-7551).
    
    Maybe add a TODO here?
    
    TODO(gregggomannn): Remove this once MESOS-7551 is resolved.



src/tests/slave_recovery_tests.cpp
Lines 914 (patched)
<https://reviews.apache.org/r/59463/#comment249236>

    What was this settle for?



src/tests/slave_recovery_tests.cpp
Lines 918 (patched)
<https://reviews.apache.org/r/59463/#comment249240>

    Can you use 'unsigned int' (i.e. only the "equivalent types" from here: http://en.cppreference.com/w/cpp/language/types)
or 'size_t' here since it's a count?



src/tests/slave_recovery_tests.cpp
Lines 955 (patched)
<https://reviews.apache.org/r/59463/#comment249235>

    Rather than pausing, resuming and pausing again, have you tried leaving the clock paused
for the whole test?


- Benjamin Mahler


On May 23, 2017, 11:59 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59463/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 11:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
>     https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new test, `SlaveRecoveryTest.PingTimeoutDuringRecovery`,
> which verifies that the agent will reply to pings from the master while it
> is performing recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
> 
> 
> Diff: https://reviews.apache.org/r/59463/diff/2/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message