mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level.
Date Tue, 23 May 2017 21:58:21 GMT


> On May 23, 2017, 9:31 p.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Lines 3787-3788 (original), 3787-3789 (patched)
> > <https://reviews.apache.org/r/59428/diff/2/?file=1730084#file1730084line3787>
> >
> >     Is this being double logged?
> >     
> >     https://github.com/apache/mesos/blob/1.3.x/3rdparty/libprocess/src/process.cpp#L1477-L1482
> 
> Anand Mazumdar wrote:
>     Good catch! Let me remove this line in a follow up review in the chain and limit
this review to just logging the `404` at the `WARNING` log level.

Added the review to remove the double logging earlier in the chain here: https://reviews.apache.org/r/59504/


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59428/#review175856
-----------------------------------------------------------


On May 23, 2017, 9:57 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59428/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures ease of debugging when a HTTP request fails due to
> access permissions (4xx errors) or when the path is not found.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 
> 
> 
> Diff: https://reviews.apache.org/r/59428/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message