mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level.
Date Tue, 23 May 2017 21:46:05 GMT


> On May 23, 2017, 9:31 p.m., Benjamin Mahler wrote:
> > Logging from libprocess seems ok at this point, although ideally the user of libprocess
could configure the logging independently from their own code.
> > 
> > I think the old strategy was, roughly, to use 1 for error, 2 for warning and 3 for
info. So so it would be great to take a little more time and do a sweep of process.cpp logging,
rather than touching these two cases and moving on, not that that's what you were planning
to do :)

I noticed this due to a user reported issue around them not being able to ascertain why their
request failed without bumping up the logging level and hardly had any intentions of doing
an audit of `process.cpp` or libprocess logging in general :-). I can file a follow up issue
to do an audit if that helps or I am open to any suggestions you might have?


> On May 23, 2017, 9:31 p.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Lines 3787-3788 (original), 3787-3789 (patched)
> > <https://reviews.apache.org/r/59428/diff/2/?file=1730084#file1730084line3787>
> >
> >     Is this being double logged?
> >     
> >     https://github.com/apache/mesos/blob/1.3.x/3rdparty/libprocess/src/process.cpp#L1477-L1482

Good catch! Let me remove this line in a follow up review in the chain and limit this review
to just logging the `404` at the `WARNING` log level.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59428/#review175856
-----------------------------------------------------------


On May 23, 2017, 8:20 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59428/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 8:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures ease of debugging when a HTTP request fails due to
> access permissions (4xx errors) or when the path is not found.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 
> 
> 
> Diff: https://reviews.apache.org/r/59428/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message