mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level.
Date Tue, 23 May 2017 20:21:29 GMT


> On May 23, 2017, 8:11 p.m., Vinod Kone wrote:
> > Do we typically do `LOG(INFO)` in libprocess? I thought we didn't since it's a 3rd
party library. The only exceptions I see are in openssl.cpp, poll_socket.cpp and profiler.cpp.
cc @bmahler
> 
> Anand Mazumdar wrote:
>     As per Till's suggestions, `WARNING` level makes more sense here for this log line.

Also, added BenM as a reviewer for more feedback if `WARNING` level is fine.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59428/#review175837
-----------------------------------------------------------


On May 23, 2017, 8:20 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59428/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 8:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures ease of debugging when a HTTP request fails due to
> access permissions (4xx errors) or when the path is not found.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 
> 
> 
> Diff: https://reviews.apache.org/r/59428/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message