-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59141/#review175834
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/uri/fetcher.hpp
Line 72 (original), 74 (patched)
<https://reviews.apache.org/r/59141/#comment249168>
add `@param data` doc comment?
include/mesos/uri/fetcher.hpp
Line 90 (original), 95 (patched)
<https://reviews.apache.org/r/59141/#comment249169>
add `@param data` doc comment?
include/mesos/uri/fetcher.hpp
Line 103 (original), 109 (patched)
<https://reviews.apache.org/r/59141/#comment249170>
add `@param data` doc comment?
- Vinod Kone
On May 22, 2017, 6:03 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59141/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 6:03 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added new parameter 'data' to the URI fetcher interface.
>
>
> Diffs
> -----
>
> include/mesos/uri/fetcher.hpp ebf86c78b794a6ef46332df788a1317bbec5d983
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
> src/tests/uri_fetcher_tests.cpp 4892909bbb47f60c95d8d9f0f175a5db32d4a164
> src/uri/fetcher.cpp f4d1a4c69e910260dc536aa42ae03fd17403b060
> src/uri/fetchers/copy.hpp f4a2fb3d5156e5ebfdf7c4202f8dc9b1cd1d6ac7
> src/uri/fetchers/copy.cpp 5e1470503f4fa0e543680c93b2ad3e36351afc1c
> src/uri/fetchers/curl.hpp 083f155092d159cd83069bfdfd905d679e9ab57c
> src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8
> src/uri/fetchers/docker.hpp 65e01cba1d41688a8ee5da73d1d6f57515fbc7f5
> src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940
> src/uri/fetchers/hadoop.hpp 4923dc6491d7cc6efc6ced4f5356af9f945ba5d2
> src/uri/fetchers/hadoop.cpp 3c5ffe607c92ea1ab66ba261bd70031f2907cea6
>
>
> Diff: https://reviews.apache.org/r/59141/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|