mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 49571: Added a benchmark test for allocations.
Date Tue, 23 May 2017 18:59:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------

(Updated May 23, 2017, 6:59 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
-------

Rebased to incorporate `AllocationInfo`.


Bugs: MESOS-5771
    https://issues.apache.org/jira/browse/MESOS-5771


Repository: mesos


Description
-------

Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
    resources; and offers from every other alternate slave contains
    a shared resource.

This test is parameterized based on number of agents, number of
frameworks and resource configuration.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 6dee2296d5a14185dbf7eee17968b20148839bfd 
  src/tests/resources_utils.hpp 1f41f02babce5c8174ea2223f4dc7470452fbaf1 
  src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff 


Diff: https://reviews.apache.org/r/49571/diff/35/

Changes: https://reviews.apache.org/r/49571/diff/34-35/


Testing (updated)
-------

All tests passed.

Allocations benchmark test results
==================================
There is no visible impact in performance when shared resources are added in the allocations.
The numbers for HEAD are prior to shared resources support (mid 2016) and the numbers indicate
improvements in allocations during this timeframe.

Following is a snapshot with 1000 agents and 200 frameworks.

With the patch (and no shared resources)
----------------------------------------
[ RUN      ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6588us
Added 1000 agents in 1.567347secs
round 0 allocate() took 1.15531secs to make 1000 offers
round 10 allocate() took 1.152876secs to make 1000 offers
round 20 allocate() took 1.15661secs to make 1000 offers
round 30 allocate() took 1.117733secs to make 1000 offers
round 40 allocate() took 1.118754secs to make 1000 offers
round 50 allocate() took 1.11169secs to make 1000 offers

With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN      ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6064us
Added 1000 agents in 1.627008secs
round 0 allocate() took 1.168253secs to make 1000 offers
round 10 allocate() took 1.146421secs to make 1000 offers
round 20 allocate() took 1.16416secs to make 1000 offers
round 30 allocate() took 1.210476secs to make 1000 offers
round 40 allocate() took 1.194251secs to make 1000 offers
round 50 allocate() took 1.17789secs to make 1000 offers

With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN      ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 6466us
Added 1000 agents in 1.568717secs
round 0 allocate() took 1.153005secs to make 1000 offers
round 10 allocate() took 1.168169secs to make 1000 offers
round 20 allocate() took 1.156774secs to make 1000 offers
round 30 allocate() took 1.183112secs to make 1000 offers
round 40 allocate() took 1.202452secs to make 1000 offers
round 50 allocate() took 1.198918secs to make 1000 offers

Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN      ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message