mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 59463: Added test for agent ping timeout during agent recovery.
Date Tue, 23 May 2017 15:08:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59463/#review175714
-----------------------------------------------------------




src/tests/slave_recovery_tests.cpp
Lines 870 (patched)
<https://reviews.apache.org/r/59463/#comment249057>

    you want to wait until the update is acked before bringing down the agent. otherwise it
might result in a status update retry messing up your expectations.


- Vinod Kone


On May 22, 2017, 9:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59463/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 9:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
>     https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new test, `SlaveRecoveryTest.PingTimeoutDuringRecovery`,
> which verifies that the agent will reply to pings from the master while it
> is performing recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
> 
> 
> Diff: https://reviews.apache.org/r/59463/diff/1/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message