mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.
Date Mon, 22 May 2017 22:27:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/#review175724
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58923, 58924, 58925, 58759, 58760, 58999, 59000, 59001, 59318, 59010, 59011,
59012, 59013, 59014, 59015, 59141, 59016, 59017, 59018]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2017, 6:04 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59018/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported Image::Secret in docker URI fetcher plugin.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
> 
> 
> Diff: https://reviews.apache.org/r/59018/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> Manually tested using mesos-execute with task group. Verified that pulling separate private
image from different registries using different image secrets works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message