mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'.
Date Mon, 22 May 2017 21:39:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59460/#review175707
-----------------------------------------------------------




src/slave/flags.cpp
Lines 335 (patched)
<https://reviews.apache.org/r/59460/#comment249049>

    s/reregister/reregistration/
    
    to be consistent with the above flag.



src/slave/flags.cpp
Lines 340 (patched)
<https://reviews.apache.org/r/59460/#comment249048>

    s/offers./offers after an agent restart./



src/slave/flags.cpp
Lines 345 (patched)
<https://reviews.apache.org/r/59460/#comment249050>

    s/to be less than/to be not more than/ ?



src/slave/slave.cpp
Lines 4204 (patched)
<https://reviews.apache.org/r/59460/#comment249051>

    re-registration


- Vinod Kone


On May 22, 2017, 6:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59460/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 6:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
>     https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new agent flag, 'executor_reregister_timeout',
> which allows operators to configure the time which an executor has
> to reregister with the agent before it will be considered gone and
> terminated.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 9c1d7245c0a8ecd657bb64dafb8b0fa4780325f4 
>   src/slave/flags.hpp 28f6482c38a2d388e624726d5e7bccc5cb260fce 
>   src/slave/flags.cpp e172aa526cfd38f4f30efda22ef011146e5c1a7d 
>   src/slave/slave.cpp 14de72fa4a8746504a251d735bf56041b934df40 
> 
> 
> Diff: https://reviews.apache.org/r/59460/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message