mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 59458: Avoid validation of agent re-registration message if possible.
Date Mon, 22 May 2017 18:37:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59458/
-----------------------------------------------------------

(Updated May 22, 2017, 6:37 p.m.)


Review request for mesos, Neil Conway and Jiang Yan Xu.


Summary (updated)
-----------------

Avoid validation of agent re-registration message if possible.


Bugs: MESOS-7538
    https://issues.apache.org/jira/browse/MESOS-7538


Repository: mesos


Description (updated)
-------

If we already have a re-registration in flight from this agent, we don't
need to validate the re-registration message since it will be dropped
anyway. Agent re-registration is a hot path after master failover,
and validating the re-registration message can be somewhat expensive.


Diffs (updated)
-----

  src/master/master.cpp e0705a532dfffd379a5bfdc3d2b095bf1c9da880 


Diff: https://reviews.apache.org/r/59458/diff/2/

Changes: https://reviews.apache.org/r/59458/diff/1-2/


Testing
-------

make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message