mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.
Date Mon, 22 May 2017 18:04:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/
-----------------------------------------------------------

(Updated May 22, 2017, 11:04 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and
Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-7088
    https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
-------

Supported Image::Secret in docker URI fetcher plugin.


Diffs (updated)
-----

  src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 


Diff: https://reviews.apache.org/r/59018/diff/4/

Changes: https://reviews.apache.org/r/59018/diff/3-4/


Testing
-------

make check

Manually tested using mesos-execute with task group. Verified that pulling separate private
image from different registries using different image secrets works correctly.


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message