mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59420: Added some comments to ContainerConfig protobuf.
Date Mon, 22 May 2017 18:02:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59420/#review175666
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 19, 2017, 10:09 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59420/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 10:09 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
>     https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These comments clarify some of the expectations of each field
> of the `ContainerConfig` protobuf, especially where fields
> are duplicated based on other fields.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 0f96334c236027780db1d88807e09685ccda4562 
> 
> 
> Diff: https://reviews.apache.org/r/59420/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message