mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 59001: Added volume secret isolator.
Date Mon, 22 May 2017 17:04:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59001/#review175639
-----------------------------------------------------------


Fix it, then Ship it!




LGTM! Fix it, ship it!


src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 29-34 (patched)
<https://reviews.apache.org/r/59001/#comment248992>

    Please re-order:
    
    ```
    #include <stout/foreach.hpp>
    #include <stout/stringify.hpp>
    #include <stout/strings.hpp>
    
    #include <stout/os/mkdir.hpp>
    #include <stout/os/write.hpp>
    ```



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 164 (patched)
<https://reviews.apache.org/r/59001/#comment248994>

    Just a nit:
    
    `const Secret&`



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 264 (patched)
<https://reviews.apache.org/r/59001/#comment249004>

    Do we have to do `force` move?


- Gilbert Song


On May 16, 2017, 12:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59001/
> -----------------------------------------------------------
> 
> (Updated May 16, 2017, 12:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added volume secret isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/slave/containerizer/mesos/containerizer.cpp 97837c83cc223950750e4cd088f4da067023c96c

>   src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 
>   src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59001/diff/9/
> 
> 
> Testing
> -------
> 
> Added new tests an ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message