mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <>
Subject Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.
Date Mon, 22 May 2017 16:52:14 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 22, 2017, 4:52 p.m.)

Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.


Rework patch to only target bytes.hpp.

Summary (updated)

Fix bytes.hpp constexpr compilation failure with GCC 7.1.

Bugs: MESOS-7520

Repository: mesos

Description (updated)

Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>'
is not a constant expression because it refers to an incompletely initialized variable`.

This patch changes around the `Bytes` class a bit by getting rid of the small classes that
extend `Bytes`.

Diffs (updated)

  3rdparty/stout/include/stout/bytes.hpp 98223db50 




`./bootstrap && mkdir build && cd build && ../configure --disable-python
--disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`


Aaron Wood

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message