mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme.
Date Fri, 19 May 2017 22:14:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/
-----------------------------------------------------------

(Updated May 19, 2017, 3:14 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Change recovery path to save the name of the container for use in later calls.


Bugs: MESOS-7449
    https://issues.apache.org/jira/browse/MESOS-7449


Repository: mesos


Description
-------

The choice of naming scheme is cosmetic.  All versions of the Docker
containerizer will consider containers starting with "mesos-"
as containers started by Mesos.  The Docker containerizer does not
consider the `SlaveID` at all when recovering.


Diffs (updated)
-----

  src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
  src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 


Diff: https://reviews.apache.org/r/58905/diff/2/

Changes: https://reviews.apache.org/r/58905/diff/1-2/


Testing (updated)
-------

See last patch in chain.

TODO: Add a backwards compatibility test .


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message