mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58903: Combined Mesos containerizer's launch methods.
Date Fri, 19 May 2017 22:11:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58903/
-----------------------------------------------------------

(Updated May 19, 2017, 3:10 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed comments.


Bugs: MESOS-7449
    https://issues.apache.org/jira/browse/MESOS-7449


Repository: mesos


Description
-------

This simplifies the container launch path by removing combining
the nested and non-nested container code paths into one.

The Mesos containerizer was originally translating the two
`containerizer->launch` entrypoints into a common method (also
called `launch`).  The previous commits moved this translation
logic into the caller (i.e. the Agent).

The end result has some slight changes:
  * It is now possible for the Agent to specify some more combinations
    of `ContainerConfig`.  For example, specifying a TaskInfo with
    a DEBUG-class container.  Or a nested container with Resources.
    We may need to add extra validation around this.
  * The `bool checkpoint` argument was replaced with a `Option<string>`
    which optionally contains an absolute path.  This allows us to
    remove the `SlaveID` field.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.hpp 04ab997454534b8e5e821b53b83e166e5018e11c

  src/slave/containerizer/mesos/containerizer.cpp 50a63b58b4960729316b0b5685793ce18ee5ce93



Diff: https://reviews.apache.org/r/58903/diff/2/

Changes: https://reviews.apache.org/r/58903/diff/1-2/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message