mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <>
Subject Review Request 59413: Fix constexpr compilation failure with GCC 7.1.
Date Fri, 19 May 2017 18:45:35 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.

Bugs: MESOS-7520

Repository: mesos


Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>'
is not a constant expression because it refers to an incompletely initialized variable`.

This patch changes around the `Bytes` class a bit by getting rid of the small classes that
extend `Bytes`. Additionally, any usage of the `Duration` class has been adjusted to not instantiate
using the base type (which triggers the issue along with `constexpr`).


  3rdparty/stout/include/stout/bytes.hpp 98223db50 
  src/master/constants.hpp 7edf9f65f 
  src/sched/constants.hpp 9edb25b38 
  src/sched/sched.cpp ef73c1dcc 
  src/scheduler/constants.hpp e3da12646 
  src/slave/constants.hpp 1159ac3b1 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp cf0466c62 
  src/slave/slave.cpp 7564e8d39 
  src/slave/status_update_manager.cpp df63a708c 



`./bootstrap && mkdir build && cd build && ../configure --disable-python
--disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`


Aaron Wood

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message