mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 58359: Update Mesos build library to use protobuf 3.3.0.
Date Fri, 19 May 2017 17:56:51 GMT


> On April 19, 2017, 5:04 p.m., Anand Mazumdar wrote:
> > src/java/mesos.pom.in
> > Line 86 (original), 86 (patched)
> > <https://reviews.apache.org/r/58359/diff/2/?file=1693769#file1693769line86>
> >
> >     hmm, does this mean frameworks would be forced to move to proto3 and not keep
using proto2?

Yes, I'd like to enforce an upgrade from framework side.


> On April 19, 2017, 5:04 p.m., Anand Mazumdar wrote:
> > src/python/interface/setup.py.in
> > Line 29 (original), 29 (patched)
> > <https://reviews.apache.org/r/58359/diff/2/?file=1693770#file1693770line29>
> >
> >     hmm, this seems to suggest that any framework using the python bindings would
be forced to use protobuf 3.2.0 and not use proto2?

Yes, ditto as above.


> On April 19, 2017, 5:04 p.m., Anand Mazumdar wrote:
> > src/python/protocol/setup.py.in
> > Line 29 (original), 29 (patched)
> > <https://reviews.apache.org/r/58359/diff/2/?file=1693772#file1693772line29>
> >
> >     Ditto as above.

Yes, ditto as above.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58359/#review172363
-----------------------------------------------------------


On May 19, 2017, 5:55 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58359/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 5:55 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-7228
>     https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update Mesos build library to use protobuf 3.3.0.
> 
> 
> Diffs
> -----
> 
>   configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b 
>   src/java/mesos.pom.in 080767f011782f048ab0244f93daea189326587c 
>   src/python/interface/setup.py.in 8e38f3feb705f08737cff93e0ed442a1f48dcbf9 
>   src/python/native_common/ext_modules.py.in e0bb335e5ae663f398cea904a0e53e3c5fb210d7

>   src/python/protocol/setup.py.in b7de10a2a099d21d6eba551ba071b6c31a1460be 
>   support/mesos-tidy/entrypoint.sh 5dbaa6086621934a7313dfa5c8008b6a6f5496f1 
> 
> 
> Diff: https://reviews.apache.org/r/58359/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message