mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59372: Disable port-mapping isolator by default.
Date Thu, 18 May 2017 18:36:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59372/#review175419
-----------------------------------------------------------


Fix it, then Ship it!





configure.ac
Lines 347 (patched)
<https://reviews.apache.org/r/59372/#comment248866>

    Should we set enable_port_mapping_isolator=no here explicitly?


- Jie Yu


On May 18, 2017, 6:28 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59372/
> -----------------------------------------------------------
> 
> (Updated May 18, 2017, 6:28 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Tim Hansen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The corresponding flag (--enable-port-mapping-isolator) was accidentally
> enabled by-default in 20dee4190838b5bc7eb9cb524af413e3fe3fe082
> (https://reviews.apache.org/r/59193/).
> 
> 
> Diffs
> -----
> 
>   configure.ac d5236700d2ab06232960f0bed43e8394e9a29aa4 
> 
> 
> Diff: https://reviews.apache.org/r/59372/diff/3/
> 
> 
> Testing
> -------
> 
> Tested the following configurations:
> Configure flag                             Isolator status
> `./configure`                                Disabled
> `./configure --with-port-mapping-isolator`   Enabled
> `./configure --with-network-isolator`        Enabled
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message