mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 59293: Windows: Fixed to retain line feeds.
Date Wed, 17 May 2017 22:13:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 17, 2017, 10:13 p.m.)

Review request for mesos and Joseph Wu.

Bugs: MESOS-7343

Repository: mesos


Write using 'wb' instead of 'w' for binary mode. This writes the
downloaded patch file exactly as it came, instead of treating as text
and changing line endings. This resolves a bug where `git apply` doesn't
always work with CRLF endings in patch files.


  support/ b495675de80fd995f208f1b9ca8c88a717cf2850 



Applied patch 59177 successfully after failing to apply it without change due to:

59177.patch:9: trailing whitespace.

59177.patch:18: trailing whitespace.
def autocomplete(cmds, plugins, config, argv):
59177.patch:26: trailing whitespace.
    current_word = argv[0]
59177.patch:27: trailing whitespace.
    argv = argv[1:]
59177.patch:36: trailing whitespace.
    return plugin_class(settings, config).__autocomplete_base__(
error: git apply: bad git-diff - expected /dev/null on line 167


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message