mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Review Request 59353: Enabled DOCKER and ROOT filter flags on Windows.
Date Wed, 17 May 2017 21:35:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59353/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Joseph Wu, and Li Li.


Repository: mesos


Description
-------

Enabled DOCKER and ROOT filter flags on Windows.


Diffs
-----

  src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
  src/tests/containerizer/docker_tests.cpp 3d3c9afbe81ebdcdf7c5542c56f9ca0e17e2484d 
  src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33 
  src/tests/environment.cpp 047798c781707c42641baa9473177ae25a451989 
  src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad 
  src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb 
  src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5 


Diff: https://reviews.apache.org/r/59353/diff/1/


Testing
-------

Tested on both Windows and Linux.  Everything passes on Linux, but there are a number of tests
that are failing on Windows. The tests that are failing on Windows are related to the tests
that are currently failing on master on Windows. These tests are failing due to some long
path changes in the Windows creators update, and I believe Andy is working on fixes to them.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message