mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.
Date Tue, 16 May 2017 01:03:54 GMT


> On May 11, 2017, 6:29 a.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp
> > Line 285 (original)
> > <https://reviews.apache.org/r/58906/diff/1/?file=1705315#file1705315line285>
> >
> >     Hum, can you point to me where do we mkdir for the sandbox?

The callstack is roughly:

* slave::paths::createExecutorDirectory: https://github.com/apache/mesos/blob/1.3.x/src/slave/paths.cpp#L543
* Slave::Framework::addExecutor: https://github.com/apache/mesos/blob/1.3.x/src/slave/slave.cpp#L6907-L6913
* `Slave::__run`: https://github.com/apache/mesos/blob/1.3.x/src/slave/slave.cpp#L2231

Which is right before the call to `containerizer->launch` in `Slave::launchExecutor`: https://github.com/apache/mesos/blob/1.3.x/src/slave/slave.cpp#L2233-L2248


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58906/#review174643
-----------------------------------------------------------


On May 1, 2017, 7:06 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58906/
> -----------------------------------------------------------
> 
> (Updated May 1, 2017, 7:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
>     https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Docker containerizer will create a stdout/stderr file as well
> `chown` the sandbox directory to the user specified at container
> creation time.  This logic is already performed elsewhere.
> 
> The stdout/stderr files will either be created prior to the container
> launch via the mesos-fetcher, or during launch via the ContainerLogger.
> 
> The sandbox directory will be `chown`d by the Agent when it
> starts to launch the executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 
> 
> 
> Diff: https://reviews.apache.org/r/58906/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message