mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58778: Supported GCE container registry.
Date Tue, 16 May 2017 00:32:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review175043
-----------------------------------------------------------


Fix it, then Ship it!





src/uri/fetchers/docker.cpp
Lines 449 (patched)
<https://reviews.apache.org/r/58778/#comment248360>

    We have getAuthHeaderBasic and now we have getBasicAuthHeader. This is really confusing.
    
    Let's use the same name `getAuthHeaderBasic` here (just different overload).



src/uri/fetchers/docker.cpp
Lines 693 (patched)
<https://reviews.apache.org/r/58778/#comment248361>

    This is pretty confusing. Can we rename this parameter `basicAuthHeaders`?


- Jie Yu


On May 15, 2017, 5:39 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58778/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 5:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7431
>     https://issues.apache.org/jira/browse/MESOS-7431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Certain registries, such as GCE registry, reply 403 instead of 401 for
> unauthorized requests. When fetching image manifests and blobs, instead
> of sending out unauthorized requests first and waiting for a possible
> 401, we should always look up the docker config and send requests with
> basic authorization when possible.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
> 
> 
> Diff: https://reviews.apache.org/r/58778/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check (covers all supported public registries)
> Manually tested on the following private registries:
> 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
> 2. Amazon ECR
> 3. Google GCR
> 4. JFrog SaaS
> 5. Local Nexus registry 3.3.1
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message