mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59279: Uses temp dir for docker and appc stores in test.
Date Mon, 15 May 2017 21:16:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/#review175025
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.cpp
Lines 180 (patched)
<https://reviews.apache.org/r/59279/#comment248344>

    no need for `mesos` here in the middle.


- Jie Yu


On May 15, 2017, 6:02 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59279/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7381
>     https://issues.apache.org/jira/browse/MESOS-7381
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Certain tests which relies on docker/appc stores to store images could be flaky when
certain changes to the store code is chaging.
> 
> This patch moves the usage of these flags to the temporary directory created for each
test case, so they do not affect each other.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6 
> 
> 
> Diff: https://reviews.apache.org/r/59279/diff/1/
> 
> 
> Testing
> -------
> 
> Ran through all tests.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message