mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.
Date Mon, 15 May 2017 18:01:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59194/
-----------------------------------------------------------

(Updated May 15, 2017, 6:01 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
-------

Addressed review comments.


Bugs: MESOS-7403
    https://issues.apache.org/jira/browse/MESOS-7403


Repository: mesos


Description (updated)
-------

Ensure that applying `DESTROY` operation removes this volume. This is
needed to handle `DESTROY` of shared volumes to ensure that the
resultant `Resources` object has this `Resource` removed (i.e. we
allow this operation to succeed if the original `Resources` object
only had a single copy of the shared resource).


Diffs (updated)
-----

  src/common/resources.cpp f6f02eb0a7ca05ab8fd9a670f32428862009b7d5 
  src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be 
  src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415 


Diff: https://reviews.apache.org/r/59194/diff/3/

Changes: https://reviews.apache.org/r/59194/diff/2-3/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message