mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
Date Mon, 15 May 2017 17:32:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/#review174990
-----------------------------------------------------------


Fix it, then Ship it!




I can fix this up before committing.


3rdparty/stout/include/stout/flags/parse.hpp
Lines 116-134 (original), 122-140 (patched)
<https://reviews.apache.org/r/58889/#comment248293>

    This part for JSON::Arrays needs the same treatment.



3rdparty/stout/tests/flags_tests.cpp
Lines 1022 (patched)
<https://reviews.apache.org/r/58889/#comment248294>

    `// __WINDOWS__`


- Joseph Wu


On May 2, 2017, noon, Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58889/
> -----------------------------------------------------------
> 
> (Updated May 2, 2017, noon)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-5937
>     https://issues.apache.org/jira/browse/MESOS-5937
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This code was deprecated for Linux, and thus makes no sense
> to port to Windows. This patch removes test from the Windows
> platform completely.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e

>   3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d 
> 
> 
> Diff: https://reviews.apache.org/r/58889/diff/2/
> 
> 
> Testing
> -------
> 
> For Linux, all tests pass. In particular, with FlagsFileTest:
> 
> [----------] 2 tests from FlagsFileTest
> [ RUN      ] FlagsFileTest.JSONFile
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a
command line option out of without using 'file:// is deprecated and will be removed in a future
release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
> [       OK ] FlagsFileTest.JSONFile (0 ms)
> [ RUN      ] FlagsFileTest.FilePrefix
> [       OK ] FlagsFileTest.FilePrefix (0 ms)
> [----------] 2 tests from FlagsFileTest (0 ms total)
> 
> For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate
for Linux. Thus, it's not run.
> 
> PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="FlagsFile*"
> Note: Google Test filter = FlagsFile*-
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FlagsFileTest
> [ RUN      ] FlagsFileTest.FilePrefix
> [       OK ] FlagsFileTest.FilePrefix (3 ms)
> [----------] 1 test from FlagsFileTest (3 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (7 ms total)
> [  PASSED  ] 1 test.
> PS C:\mesos\mesos>
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message