mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.
Date Mon, 15 May 2017 17:16:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59156/#review174986
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On May 10, 2017, 1:34 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59156/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 1:34 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7497
>     https://issues.apache.org/jira/browse/MESOS-7497
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes a CMake anti-pattern where `set` was used to append to a
> variable, instead of the more explicit `list(APPEND)` or
> `string(APPEND)` alternatives.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a 
> 
> 
> Diff: https://reviews.apache.org/r/59156/diff/1/
> 
> 
> Testing
> -------
> 
> Re-configured and built on Windows.
> 
> NOTE: This syntax should be preferred going forward. There are more instances of the
anti-pattern the setting of source files, but we'll take care of it in a later patch to avoid
too much churn.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message