mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 59001: Added volume secret isolator.
Date Mon, 15 May 2017 15:45:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59001/#review174945
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/volume/secret.hpp
Lines 50-52 (patched)
<https://reviews.apache.org/r/59001/#comment248245>

    Ditto.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 101-106 (patched)
<https://reviews.apache.org/r/59001/#comment248246>

    Ditto.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 126 (patched)
<https://reviews.apache.org/r/59001/#comment248256>

    Should we return a `None()` here? Otherwise, a debug container may always get a failure
from isolator::prepare since the `environment_secret` isolator is always enabled.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 289 (patched)
<https://reviews.apache.org/r/59001/#comment248258>

    two more space.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 298 (patched)
<https://reviews.apache.org/r/59001/#comment248257>

    Use `collect`?


- Gilbert Song


On May 12, 2017, 10:53 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59001/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 10:53 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added volume secret isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/slave/containerizer/mesos/containerizer.cpp 97837c83cc223950750e4cd088f4da067023c96c

>   src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 
>   src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59001/diff/8/
> 
> 
> Testing
> -------
> 
> Added new tests an ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message