mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58486: Update the allocator on a per offer operation.
Date Fri, 12 May 2017 12:27:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review174780
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59194, 59195, 58486]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 11, 2017, 8:21 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 8:21 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7308
>     https://issues.apache.org/jira/browse/MESOS-7308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
> 
> 1) Launch or Launch Group: We launch the tasks or task group on the
>    agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
>    the `CheckPointResourcesMessage` to the agent.
> 
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
>   src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
> 
> 
> Diff: https://reviews.apache.org/r/58486/diff/4/
> 
> 
> Testing
> -------
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message